Bug 36364 Space allotted for text doesn't grow to accomodate letter-spacing when applied
Bug 70251 Form widgets all have different heights and baselines
Bug 79927 submit button with single character value is too small
Bug 128115 button tag does not handle height correctly
Bug 167236 Text/password inputs should be aligned to baseline
I'm hoping that the 2002111211 build that I'm using does not contain these fixes (all the above are actually fixed by the fix for bug 167236), since when I go to b.m.o. and look at the actions section at the bottom, alignment still looks wrong to me. (Ex. The text of the "Find" button does not line up with "Query" or "bug #", nor does text typed into the "bug #" text box line up with other text.) Now, this may just be my wrong perception of what "should" happen, but even if I believe that the bottom of the "Find" button should line up with the bottom of the surrounding text, throwing off the text inside the button, then the bottom of the "bug #" text box should ALSO line up with the bottom of the surround text - and it doesn't. Moreover, just look at the vertical positioning of the form elements as a whole - very jagged.
I'll wait and see if the 11/13 builds correct this or not. (If not, either it's not actually fixed - or the above bugs don't address what I'm seeing.)
Fixed: Several more form button / form text alignment bugs.
-
old jasonb
- Moderator
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
-
bzbarsky
- Posts: 478
- Joined: November 5th, 2002, 1:36 pm
Re: Fixed: Several more form button / form text alignment bu
> I'm hoping that the 2002111211 build that I'm using does not contain these fixes
It does not. These landed at 2002-11-12 11:17 (except for a change to nsTextControlFrame that did not land till 2002-11-12 23:50). So testing with the 2002-11-13 morning builds is the only thing that makes sense (there will be some weirdness with file inputs in the 2002-11-12 evening builds :( ).
As for you description of what you think "should" happen, it's pretty much on the money. ;)
It does not. These landed at 2002-11-12 11:17 (except for a change to nsTextControlFrame that did not land till 2002-11-12 23:50). So testing with the 2002-11-13 morning builds is the only thing that makes sense (there will be some weirdness with file inputs in the 2002-11-12 evening builds :( ).
As for you description of what you think "should" happen, it's pretty much on the money. ;)
-
old jasonb
- Moderator
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
Also fixed:
bug 108424 button sizes differently from input type="submit"
bug 157124 button element confuses left and right padding
bug 108424 button sizes differently from input type="submit"
bug 157124 button element confuses left and right padding
-
old jasonb
- Moderator
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
Confirming: Build 2002111304 contains all of the bug fixes and the actions section of the b.m.o. page now looks very nice.
Today is a good day to browse! <grin>
Today is a good day to browse! <grin>
-
herman
- Posts: 1034
- Joined: November 7th, 2002, 3:45 pm
JBassford wrote:Confirming: Build 2002111304 contains all of the bug fixes and the actions section of the b.m.o. page now looks very nice.
Today is a good day to browse! <grin>
I´ve had bad luck, downloaded that build as win-talkback.zip from komodo twice, but couldn´t unzip it. Tested with a hexeditor: I had been downloading all zeros. Build 2002111308 is working fine ;-)