Can I disable opening bookmarks in tabs

Post by **old Neil Parks** » February 5th, 2003, 4:33 pm

I have a bookmark dropdown menu open, and I happen to press the letter "O".

One of three things will happen:

If the folder has more than one bookmark whose name begins with letter "O", one of them will be highlighted. That's okay.

If the folder has only one bookmark starting with "O", it will open. That might not be what I want, but it's not so bad.

But if that folder doesn't have any bookmarks starting with letter "o"--LOOK OUT! The dreaded Open in Tabs will kick in without warning, and if the folder happens to have a lot of bookmarks... OUCH!

Is there any way to disable this behavior?

You may ask, Why would I press "o" if I don't have any bookmarks in that folder that start with "o"? Two possibilities: I forgot that there weren't any, or I was aiming for "I" or "P" but hit "O" by mistake.

I would like to see "O" take no action in this case, or, at worst, just highlight the "open in tabs" but not activate it.

(FWIW, using 1/31 in Win ME.)

AtomB · Post by **AtomB** » February 6th, 2003, 2:53 am

heck i would just like to see the open in tabs removed from the bookmark folders. i've done similar to your pressing the letter O, sometimes tring to select the last bookmark in the folder and opps clicked to far down and bam, 20 tabs open up. not a fun thing.

Post by **alanjstr** » February 6th, 2003, 10:04 am

I'm sure someone could write an extension that would remove the context menu items. I'm not sure about the access keys, though.

You could put something in userChrome.css to remove the context menu item.

cdn · Post by **cdn** » February 6th, 2003, 11:41 am

alanjstr wrote:I'm sure someone could write an extension that would remove the context menu items. I'm not sure about the access keys, though.

You could put something in userChrome.css to remove the context menu item.

could probably map the accesskey to something else like '¬'

which would require an override to the entry in browser.dtd

or as you say userChrome.css it, although I cannot find (via DOM Inspector) a reference to 'Open in Tabs' : (

Post by **alanjstr** » February 6th, 2003, 12:17 pm

cdn wrote:although I cannot find (via DOM Inspector) a reference to 'Open in Tabs' : (

Guess you'll have to grep.

cdn · Post by **cdn** » February 6th, 2003, 12:42 pm

I don't think it's as simple as that, since the bookmark menu is

constructed by xul template from

the rdf interpretation of

the html

relevant 'code' is in browser.xul, wherever it happens to be in there

edit:

from grepping 'Open in Tabs'

src/mozilla/browser/components/bookmarks/locale/bookmarks.properties:cmd_bm_openfolder = Open in Tabs
src/mozilla/browser/components/bookmarks/locale/bookmarks.properties:cmd_bm_openfolder_accesskey = O

so that is en-US.jar locale/browser/bookmarks/bookmarks.properties

which then leads to grep for 'cmd_bm_openfolder'

src/mozilla/browser/components/bookmarks/content/bookmarks.js: case "cmd_bm_openfolder":

src/mozilla/browser/components/bookmarks/content/bookmarksToolbar.xml: element.setAttribute("label", BookmarksUtils.getLocaleString("cmd_bm_openfolder"));

src/mozilla/browser/components/bookmarks/content/bookmarksToolbar.xml: element.setAttribute("accesskey", BookmarksUtils.getLocaleString("cmd_bm_openfolder_accesskey"));

--

so it looks like an adjustment of browser.jar : content/browser/bookmarks/bookmarksToolbar.xml is required ?

Post by **alanjstr** » February 6th, 2003, 1:08 pm

So you can probably key off of that label.

cdn · Post by **cdn** » February 6th, 2003, 1:27 pm

although from looking in the xml

I found a different reference

browser.jar : browser/content/browser.xul: onpopupshowing="document.getElementById('bookmarks-toolbar').showOpenInTabsMenuItem(event.originalTarget)"

so it's probably the onpopupshowing that needs overriding

cdn · Post by **cdn** » February 6th, 2003, 1:30 pm

specifically

Code: Select all

            <menu id="bookmarks-menu" label="&bookmarksMenu.label;" accesskey="&bookmarksMenu.accesskey;"
                  datasources="rdf:bookmarks rdf:files rdf:localsearch rdf:internetsearch"
                  ref="NC:BookmarksRoot" flags="dont-test-empty"
                  onpopupshowing="document.getElementById('bookmarks-toolbar').showOpenInTabsMenuItem(event.originalTarget)"

cdn · Post by **cdn** » February 6th, 2003, 1:36 pm

userChrome.css :

Code: Select all


#openintabs-menuitem {
  display: none !important;
}

currently leaves the separator at the foot of the menu

Post by **alanjstr** » February 6th, 2003, 1:40 pm

<i>something</i>[label="Open in New Tab"] ?

cdn · Post by **cdn** » March 6th, 2003, 3:35 pm

alanjstr wrote:<i>something</i>[label="Open in New Tab"] ?

what something - are you thinking of something for userChrome.css ?

Post by **old Neil Parks** » March 6th, 2003, 4:03 pm

cdn wrote:

Code: Select all

       onpopupshowing="document.getElementById('bookmarks-toolbar').showOpenInTabsMenuItem(event.originalTarget)"

I saw the above line in several places in browser.xul, and in each case it was followed by a line mentioning
"hideOpenInTabsMenuItem".

So I did a global search and replace to change all occurrences of "showOpenInTabsMenuItem" to "hideOpenInTabsMenuItem".

Seems to work perfectly. Thanks!

But such editiing should not be necessary, IMNSHO. The default behavior should be as I said originally:

I would like to see "O" take no action in this case, or, at worst, just highlight the "open in tabs" but not activate it.

AGSHender · Post by **AGSHender** » March 6th, 2003, 7:17 pm

You could just use a mouse like the rest of us for navigation....

But seriously, though, I like the feature, but I agree with others, it should boobytrapped somehow so that simple things like that can't open it. Is it possible to map something like Alt-O with the menu open? I've never seen a double-key stroke in a menu, so I don't even know if it's possible, although I'm sure if it were easy it would have been done in other apps before now.